From c9e752ab18f43758d704951f7f31e39dafa6fdb4 Mon Sep 17 00:00:00 2001 From: Douglas Bagnall Date: Thu, 28 Aug 2025 17:09:43 +1200 Subject: [PATCH] dsdb:audit: bump minor version of password logs (1.1 -> 1.2) In https://wiki.samba.org/index.php/Interpreting_JSON_Audit_Logs we say: > a version number for the JSON format. It has two parts. > > major: incremented if fields change meaning > minor: incremented if a field is added > > A change in possible values does not usually trigger a version > change. This is obviously true for client supplied data, but also > applies to e.g. passwordType, where the set of supported password > formats can change over time without changing the JSON version. The last paragraph explicitly exempts us from a version change for adding a new possible value ("Public key change") to the "action" field. On the other hand we have expanded the scope of the log, which deserves some version recognition. Signed-off-by: Douglas Bagnall Reviewed-by: Gary Lockyer --- source4/dsdb/samdb/ldb_modules/audit_log.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/source4/dsdb/samdb/ldb_modules/audit_log.c b/source4/dsdb/samdb/ldb_modules/audit_log.c index b70cd04dad9..dd730c82e0a 100644 --- a/source4/dsdb/samdb/ldb_modules/audit_log.c +++ b/source4/dsdb/samdb/ldb_modules/audit_log.c @@ -44,7 +44,7 @@ #define PASSWORD_JSON_TYPE "passwordChange" #define PASSWORD_HR_TAG "Password Change" #define PASSWORD_MAJOR 1 -#define PASSWORD_MINOR 1 +#define PASSWORD_MINOR 2 #define PASSWORD_LOG_LVL 5 #define TRANSACTION_JSON_TYPE "dsdbTransaction" -- 2.47.3