From cb1a75fc9e8d162eaa4777de313cd005c0742b01 Mon Sep 17 00:00:00 2001 From: Eric Leblond Date: Fri, 25 Nov 2011 18:40:34 +0100 Subject: [PATCH] TLS parser: modify OCTETSTRING This patch does on over allocation of 1 for the OCTETSTRING to be able to add a 0 at the end. This will then allow us to use the string in printf. --- src/util-decode-der.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/util-decode-der.c b/src/util-decode-der.c index 8f7974b267..2f530b84a7 100644 --- a/src/util-decode-der.c +++ b/src/util-decode-der.c @@ -505,12 +505,15 @@ static Asn1Generic * DecodeAsn1DerOctetString(const unsigned char *buffer, uint3 return NULL; a->type = ASN1_OCTETSTRING; a->strlen = length; - a->str = SCMalloc(length); + /* Add one to the octet string for the 0. This will then + * allow us to use the string in printf */ + a->str = SCMalloc(length + 1); if (a->str == NULL) { SCFree(a); return NULL; } memcpy(a->str, (const char*)d_ptr, length); + a->str[length] = 0; d_ptr += length; -- 2.47.2