From cb1b013b265e0e4f13b7a2d2a06dbd39091cc05f Mon Sep 17 00:00:00 2001 From: "Darrick J. Wong" Date: Thu, 31 May 2018 19:38:54 -0500 Subject: [PATCH] xfs_io: fix signed comparison problem in copy_file_range cvtnum() returns a signed long long, so the type of 'len' should be a signed type so that a user entering a negative length doesn't produce some huge positive integer. The negative len check demands it anyway. Coverity-id: 1435895 Fixes: 25b4549 ("xfs_io: Make copy_range arguments understand *iB values") Signed-off-by: Darrick J. Wong Reviewed-by: Eric Sandeen Signed-off-by: Eric Sandeen --- io/copy_file_range.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/io/copy_file_range.c b/io/copy_file_range.c index ebd1ec764..4d0770ef2 100644 --- a/io/copy_file_range.c +++ b/io/copy_file_range.c @@ -91,7 +91,7 @@ copy_range_f(int argc, char **argv) { long long src = 0; long long dst = 0; - size_t len = 0; + long long len = 0; int opt; int ret; int fd; -- 2.47.2