From cbef472558ca50d282414e68083717c44b92ad62 Mon Sep 17 00:00:00 2001 From: =?utf8?q?=C3=81lvaro=20Herrera?= Date: Mon, 9 Feb 2026 19:15:20 +0100 Subject: [PATCH] Remove HeapTupleheaderSetXminCommitted/Invalid functions They are not and never have been used by any known code -- apparently we just cargo-culted them in commit 37484ad2aace (or their ancestor macros anyway, which begat these functions in commit 34694ec888d6). Allegedly they're also potentially dangerous; users are better off going through HeapTupleSetHintBits instead. Author: Andy Fan Discussion: https://postgr.es/m/87sejogt4g.fsf@163.com --- src/include/access/htup_details.h | 14 -------------- 1 file changed, 14 deletions(-) diff --git a/src/include/access/htup_details.h b/src/include/access/htup_details.h index d406825ff22..75f8b159b8a 100644 --- a/src/include/access/htup_details.h +++ b/src/include/access/htup_details.h @@ -357,20 +357,6 @@ HeapTupleHeaderXminFrozen(const HeapTupleHeaderData *tup) return (tup->t_infomask & HEAP_XMIN_FROZEN) == HEAP_XMIN_FROZEN; } -static inline void -HeapTupleHeaderSetXminCommitted(HeapTupleHeaderData *tup) -{ - Assert(!HeapTupleHeaderXminInvalid(tup)); - tup->t_infomask |= HEAP_XMIN_COMMITTED; -} - -static inline void -HeapTupleHeaderSetXminInvalid(HeapTupleHeaderData *tup) -{ - Assert(!HeapTupleHeaderXminCommitted(tup)); - tup->t_infomask |= HEAP_XMIN_INVALID; -} - static inline void HeapTupleHeaderSetXminFrozen(HeapTupleHeaderData *tup) { -- 2.47.3