From cbf451388f562d40d8576b3884166ca620d4e655 Mon Sep 17 00:00:00 2001 From: Libo Chen Date: Tue, 10 Sep 2013 08:11:56 +0200 Subject: [PATCH] cgcreate: add err check cgroup still can be created even if giving invalid -d,-f,-s parameter e.g. cgcreate -g cpu:/test -d 888 "888" is invalid, but test will be cgreated. So we should exit if -d,-f or -s is invalid v2: - add nonzero return value Signed-off-by: Libo Chen Acked-by: Ivana Hutarova Varekova --- src/tools/cgcreate.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/tools/cgcreate.c b/src/tools/cgcreate.c index b0003b1e..f1920eab 100644 --- a/src/tools/cgcreate.c +++ b/src/tools/cgcreate.c @@ -139,14 +139,20 @@ int main(int argc, char *argv[]) case 'd': dirm_change = 1; ret = parse_mode(optarg, &dir_mode, argv[0]); + if (ret) + goto err; break; case 'f': filem_change = 1; ret = parse_mode(optarg, &file_mode, argv[0]); + if (ret) + goto err; break; case 's': filem_change = 1; ret = parse_mode(optarg, &tasks_mode, argv[0]); + if (ret) + goto err; break; default: usage(1, argv[0]); -- 2.47.2