From ce2483f6199a2d623f142a992a6afe41015d9ad8 Mon Sep 17 00:00:00 2001 From: =?utf8?q?J=C3=A1n=20Tomko?= Date: Sun, 2 Aug 2020 23:30:17 +0200 Subject: [PATCH] virsh: completer: use signed variable for XPathNodeSet errors MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit Although virXPathNodeSet is unlikely to return -1, we should check for it properly or not at all. Signed-off-by: Ján Tomko Reviewed-by: Martin Kletzander --- tools/virsh-completer-host.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/virsh-completer-host.c b/tools/virsh-completer-host.c index 35e6bba661..8893888ec2 100644 --- a/tools/virsh-completer-host.c +++ b/tools/virsh-completer-host.c @@ -55,7 +55,7 @@ virshAllocpagesPagesizeCompleter(vshControl *ctl, { g_autoptr(xmlXPathContext) ctxt = NULL; virshControlPtr priv = ctl->privData; - unsigned int npages = 0; + int npages = 0; g_autofree xmlNodePtr *pages = NULL; g_autoptr(xmlDoc) doc = NULL; size_t i = 0; @@ -106,7 +106,7 @@ virshCellnoCompleter(vshControl *ctl, { g_autoptr(xmlXPathContext) ctxt = NULL; virshControlPtr priv = ctl->privData; - unsigned int ncells = 0; + int ncells = 0; g_autofree xmlNodePtr *cells = NULL; g_autoptr(xmlDoc) doc = NULL; size_t i = 0; -- 2.47.2