From ce870730e78b86b92f2bcad39514840965918508 Mon Sep 17 00:00:00 2001 From: Dylan Hardison Date: Tue, 22 Dec 2015 13:34:38 -0500 Subject: [PATCH] Bug 1232785 - [SECURITY] Buglists in CSV format can be parsed as valid javascript in some browsers r=dkl,a=dkl --- Bugzilla/Template.pm | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Bugzilla/Template.pm b/Bugzilla/Template.pm index 72d899c4d7..cfcbc66554 100644 --- a/Bugzilla/Template.pm +++ b/Bugzilla/Template.pm @@ -719,6 +719,9 @@ sub create { { my ($var) = @_; $var = ' ' . $var if substr($var, 0, 1) eq '='; + # backslash is not special to CSV, but it can be used to confuse some browsers... + # so we do not allow it to happen. We only do this for logged-in users. + $var =~ s/\\/\x{FF3C}/g if Bugzilla->user->id; $var =~ s/\"/\"\"/g; if ($var !~ /^-?(\d+\.)?\d*$/) { $var = "\"$var\""; -- 2.47.2