From cee9d53c157ddc4094299eb8782caca4684f5b4a Mon Sep 17 00:00:00 2001 From: "kiko%async.com.br" <> Date: Thu, 5 Aug 2004 20:48:53 +0000 Subject: [PATCH] Branch fix for bug 253562: Hours Worked (actual_time) is being listed as 1. Cleans up Bugzilla::Bug::actual_time to do things the right way (dbi, Bugzilla->user) and apparently fixes a problem limited to some platforms. r=joel, a218=justdave. --- Bugzilla/Bug.pm | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/Bugzilla/Bug.pm b/Bugzilla/Bug.pm index f1a1cf3417..20c131e227 100755 --- a/Bugzilla/Bug.pm +++ b/Bugzilla/Bug.pm @@ -288,12 +288,14 @@ sub actual_time { return $self->{'actual_time'} if exists $self->{'actual_time'}; - if (&::UserInGroup(Param("timetrackinggroup"))) { - &::SendSQL("SELECT SUM(work_time) - FROM longdescs WHERE longdescs.bug_id=$self->{bug_id}"); - $self->{'actual_time'} = &::FetchSQLData(); - } - + return undef unless (Bugzilla->user && + Bugzilla->user->in_group(Param("timetrackinggroup"))); + + my $sth = Bugzilla->dbh->prepare("SELECT SUM(work_time) + FROM longdescs + WHERE longdescs.bug_id=?"); + $sth->execute($self->{bug_id}); + $self->{'actual_time'} = $sth->fetchrow_array(); return $self->{'actual_time'}; } -- 2.47.2