From cf16ae56338b59aaa517de5a85ea8c86c77bbaf7 Mon Sep 17 00:00:00 2001 From: Michael Adam Date: Thu, 23 Jul 2015 16:29:23 +0200 Subject: [PATCH] tests:docs: test the diff between the static and generated table This proves that the committed and the generated parameter tables are identical (modulo order). Signed-off-by: Michael Adam Reviewed-by: Jeremy Allison --- python/samba/tests/docs.py | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) diff --git a/python/samba/tests/docs.py b/python/samba/tests/docs.py index dc5e2129d7a..510dafa6f77 100644 --- a/python/samba/tests/docs.py +++ b/python/samba/tests/docs.py @@ -265,6 +265,25 @@ class SmbDotConfTests(TestCase): self.fail(self._format_message(undocumented, "Parameters that are in the implementation but undocumented:")) + def test_generated(self): + diff1 = self.table_static.difference(self.table_gen) + diff1_txt = "" + if len(diff1) > 0: + diff1_txt = self._format_message(diff1, + "Parameter diff viewed from static (%d entries):" + % (len(diff1))) + + diff2 = self.table_gen.difference(self.table_static) + diff2_txt = "" + if len(diff2) > 0: + diff2_txt = self._format_message(diff2, + "Parameter diff viewed from generated (%d entries):" % + (len(diff2))) + + if len(diff1) > 0 or len(diff2) > 0: + self.fail("Parameter tables are different.\n%s\n%s" % + (diff1_txt, diff2_txt)) + def test_default_s3(self): self._test_default(['bin/testparm']) self._set_defaults(['bin/testparm']) -- 2.47.2