From cfa70237d62af6309f48ab4eae84ac0f5173d0b9 Mon Sep 17 00:00:00 2001 From: Matthieu Baerts Date: Wed, 23 Aug 2023 09:24:07 +0200 Subject: [PATCH] ss: mptcp: display seq related counters as decimal This is aligned with what is printed for TCP sockets. The main difference here is that these counters can be larger (u32 vs u64) but WireShark and TCPDump are also printing these MPTCP counters as decimal and they look fine. So it sounds better to do the same here with ss for those who want to easily count how many bytes have been exchanged between two runs without having to think in hexa. Acked-by: Paolo Abeni Acked-by: Andrea Claudi Signed-off-by: Matthieu Baerts Signed-off-by: Stephen Hemminger --- misc/ss.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/misc/ss.c b/misc/ss.c index 7ce73e610..e7dc44f33 100644 --- a/misc/ss.c +++ b/misc/ss.c @@ -3250,11 +3250,11 @@ static void mptcp_stats_print(struct mptcp_info *s) if (s->mptcpi_token) out(" token:%x", s->mptcpi_token); if (s->mptcpi_write_seq) - out(" write_seq:%llx", s->mptcpi_write_seq); + out(" write_seq:%llu", s->mptcpi_write_seq); if (s->mptcpi_snd_una) - out(" snd_una:%llx", s->mptcpi_snd_una); + out(" snd_una:%llu", s->mptcpi_snd_una); if (s->mptcpi_rcv_nxt) - out(" rcv_nxt:%llx", s->mptcpi_rcv_nxt); + out(" rcv_nxt:%llu", s->mptcpi_rcv_nxt); } static void mptcp_show_info(const struct nlmsghdr *nlh, struct inet_diag_msg *r, -- 2.47.2