From cfe0bfd911fc318c47f52bf8ac3ddb972c5ed86a Mon Sep 17 00:00:00 2001 From: Mike Bayer Date: Thu, 12 Jul 2018 22:55:01 -0400 Subject: [PATCH] Correct fastexecutemany test for lower pyodbc version some builds on CI have a pyodbc that is < 4.0.19, make the check more specific Change-Id: I69b33c2367d4a03adb00bcf52fb6d1483b0327f8 --- test/requirements.py | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/test/requirements.py b/test/requirements.py index 147b708c83..1d11cea470 100644 --- a/test/requirements.py +++ b/test/requirements.py @@ -1083,13 +1083,17 @@ class DefaultRequirements(SuiteRequirements): def has_fastexecutemany(config): if not against(config, "mssql+pyodbc"): return False + if config.db.dialect._dbapi_version() < (4, 0, 19): + return False with config.db.connect() as conn: drivername = conn.connection.connection.getinfo( config.db.dialect.dbapi.SQL_DRIVER_NAME) # on linux this is 'libmsodbcsql-13.1.so.9.2'. # don't know what it is on windows return "msodbc" in drivername - return only_if(has_fastexecutemany) + return only_if( + has_fastexecutemany, + "only on pyodbc > 4.0.19 w/ msodbc driver") @property def python_fixed_issue_8743(self): -- 2.47.2