From d135100a42d08aed24e6c24ad229974f9a12c424 Mon Sep 17 00:00:00 2001 From: Florian Krohm Date: Sun, 22 Apr 2012 02:48:20 +0000 Subject: [PATCH] Consolidate and update information about dependencies of VG_(machine_get_hwcaps) for all architectures in pub_core_machine.h and avoid double maintenance. git-svn-id: svn://svn.valgrind.org/valgrind/trunk@12532 --- coregrind/m_machine.c | 30 +----------------------------- coregrind/pub_core_machine.h | 4 ++++ 2 files changed, 5 insertions(+), 29 deletions(-) diff --git a/coregrind/m_machine.c b/coregrind/m_machine.c index 3f30a0626c..bdceb58db9 100644 --- a/coregrind/m_machine.c +++ b/coregrind/m_machine.c @@ -356,35 +356,7 @@ SizeT VG_(thread_get_altstack_size)(ThreadId tid) (2) from the AT_SYSINFO entries the kernel gave us (ppc32 cache line size). It's a bit nasty in the sense that there's no obvious way to stop uses of some of this info before it's ready to go. - - Current dependencies are: - - x86: initially: call VG_(machine_get_hwcaps) - - then safe to use VG_(machine_get_VexArchInfo) - and VG_(machine_x86_have_mxcsr) - ------------- - amd64: initially: call VG_(machine_get_hwcaps) - - then safe to use VG_(machine_get_VexArchInfo) - ------------- - ppc32: initially: call VG_(machine_get_hwcaps) - call VG_(machine_ppc32_set_clszB) - - then safe to use VG_(machine_get_VexArchInfo) - and VG_(machine_ppc32_has_FP) - and VG_(machine_ppc32_has_VMX) - ------------- - ppc64: initially: call VG_(machine_get_hwcaps) - call VG_(machine_ppc64_set_clszB) - - then safe to use VG_(machine_get_VexArchInfo) - and VG_(machine_ppc64_has_VMX) - - ------------- - s390x: initially: call VG_(machine_get_hwcaps) - - then safe to use VG_(machine_get_VexArchInfo) + See pub_core_machine.h for more information about that. VG_(machine_get_hwcaps) may use signals (although it attempts to leave signal state unchanged) and therefore should only be diff --git a/coregrind/pub_core_machine.h b/coregrind/pub_core_machine.h index 6f15be5385..b76f395f9b 100644 --- a/coregrind/pub_core_machine.h +++ b/coregrind/pub_core_machine.h @@ -169,6 +169,10 @@ void VG_(get_UnwindStartRegs) ( /*OUT*/UnwindStartRegs* regs, call VG_(machine_arm_set_has_NEON) then safe to use VG_(machine_get_VexArchInfo) + ------------- + s390x: initially: call VG_(machine_get_hwcaps) + + then safe to use VG_(machine_get_VexArchInfo) VG_(machine_get_hwcaps) may use signals (although it attempts to leave signal state unchanged) and therefore should only be -- 2.47.2