From d166acbdabd4c3ad4be655040ea64c2e257c6717 Mon Sep 17 00:00:00 2001 From: Shivani Bhardwaj Date: Tue, 7 Sep 2021 05:50:11 +0530 Subject: [PATCH] applayer: error if probes are null but port is not If the default port is set via the Rust registration table but the probe fns to server and to client are set to None, the port is never used. Setting port in such a case is useless so error out. --- src/app-layer-register.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/app-layer-register.c b/src/app-layer-register.c index dcf82aa8b7..fe2e80bc74 100644 --- a/src/app-layer-register.c +++ b/src/app-layer-register.c @@ -55,6 +55,7 @@ AppProto AppLayerRegisterProtocolDetection(const struct AppLayerParser *p, int e AppLayerProtoDetectRegisterProtocol(alproto, p->name); if (p->ProbeTS == NULL && p->ProbeTC == NULL) { + BUG_ON(p->default_port != NULL); return alproto; } -- 2.47.2