From d190424105ed9c0d376842f95ae64edc15b3d9e0 Mon Sep 17 00:00:00 2001 From: Yi Wang Date: Thu, 25 May 2017 22:39:48 -0400 Subject: [PATCH] node_device: fix memory leak in nodeDeviceSysfsGetSCSIHostCaps @tmp is leaked after the second call to virVHBAGetConfig within virVHBAIsVportCapable code block because it wasn't freed after making the first call to the function. Signed-off-by: Yi Wang Signed-off-by: Erik Skultety --- src/node_device/node_device_linux_sysfs.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/node_device/node_device_linux_sysfs.c b/src/node_device/node_device_linux_sysfs.c index 1b7aa9435c..ecfe34d419 100644 --- a/src/node_device/node_device_linux_sysfs.c +++ b/src/node_device/node_device_linux_sysfs.c @@ -95,8 +95,9 @@ nodeDeviceSysfsGetSCSIHostCaps(virNodeDevCapSCSIHostPtr scsi_host) goto cleanup; } - if (!(tmp = virVHBAGetConfig(NULL, scsi_host->host, - "npiv_vports_inuse"))) { + VIR_FREE(tmp); + if (!(tmp = virVHBAGetConfig(NULL, scsi_host->host, + "npiv_vports_inuse"))) { VIR_WARN("Failed to read npiv_vports_inuse for host%d", scsi_host->host); goto cleanup; -- 2.47.2