From d233ff0f984a1f9d0b166701b19e1897b05812d6 Mon Sep 17 00:00:00 2001 From: Maxim Petrov Date: Sat, 21 Oct 2023 10:44:08 +0200 Subject: [PATCH] ss: fix directory leak when -T option is used To get information about threads used in a process, the /proc/$PID/task directory content is analyzed by ss code. However, the opened 'dirent' object is not closed after use, leading to memory leaks. Add missing closedir call in 'user_ent_hash_build' to avoid it. Detected by valgrind: "valgrind ./misc/ss -T" Fixes: e2267e68b9b5 ("ss: Introduce -T, --threads option") Signed-off-by: Maxim Petrov Signed-off-by: Stephen Hemminger --- misc/ss.c | 1 + 1 file changed, 1 insertion(+) diff --git a/misc/ss.c b/misc/ss.c index 7e67dbe4a..2628c2e04 100644 --- a/misc/ss.c +++ b/misc/ss.c @@ -678,6 +678,7 @@ static void user_ent_hash_build(void) snprintf(name + nameoff, sizeof(name) - nameoff, "%d/", tid); user_ent_hash_build_task(name, pid, tid); } + closedir(task_dir); } } closedir(dir); -- 2.47.2