From d24ff2e87d9c00a9ebbd5bece0f0c94474939e05 Mon Sep 17 00:00:00 2001 From: "Alan T. DeKok" Date: Wed, 13 Apr 2022 08:55:00 -0400 Subject: [PATCH] use CMP() CID #1503972 --- src/listen/radius/proto_radius_udp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/listen/radius/proto_radius_udp.c b/src/listen/radius/proto_radius_udp.c index 0169d414025..78541c14545 100644 --- a/src/listen/radius/proto_radius_udp.c +++ b/src/listen/radius/proto_radius_udp.c @@ -395,7 +395,7 @@ static int8_t session_cmp(void const *one, void const *two) { proto_radius_udp_state_t const *a = (proto_radius_udp_state_t const *) one; proto_radius_udp_state_t const *b = (proto_radius_udp_state_t const *) two; - int rcode; + uint8_t rcode; fr_assert(a->state != NULL); fr_assert(b->state != NULL); @@ -403,7 +403,7 @@ static int8_t session_cmp(void const *one, void const *two) rcode = CMP(a->len, b->len); if (!rcode) return rcode; - return memcmp(a->state, b->state, a->len); + return CMP(memcmp(a->state, b->state, a->len), 0); } -- 2.47.3