From d2a430f90a8d63ed76d2b2cf1c58a9c6260a6fac Mon Sep 17 00:00:00 2001 From: =?utf8?q?J=C3=A1n=20Tomko?= Date: Sat, 18 Mar 2023 12:33:17 +0100 Subject: [PATCH] vbox: remove unreachable error in virVBoxSnapshotConfLoadVboxFile MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit Both callers in the VirtualBox driver error out if the path can't be fetched via VirtualBox APIs and abort on conversion error from UTF-16 to UTF-8. Signed-off-by: Ján Tomko Reviewed-by: Laine Stump --- src/vbox/vbox_snapshot_conf.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/src/vbox/vbox_snapshot_conf.c b/src/vbox/vbox_snapshot_conf.c index 2f3f48d688..a6e5fad4d2 100644 --- a/src/vbox/vbox_snapshot_conf.c +++ b/src/vbox/vbox_snapshot_conf.c @@ -576,12 +576,6 @@ virVBoxSnapshotConfLoadVboxFile(const char *filePath, ssize_t searchResultSize = 0; char *currentSnapshotAttribute = NULL; - if (filePath == NULL) { - virReportError(VIR_ERR_INTERNAL_ERROR, "%s", - _("Filepath is Null")); - goto cleanup; - } - machineDescription = g_new0(virVBoxSnapshotConfMachine, 1); xml = virXMLParse(filePath, NULL, NULL, NULL, &xPathContext, NULL, false); -- 2.47.2