From d3221f16978186b09531f7ea0cb5b92b20147181 Mon Sep 17 00:00:00 2001 From: Eduardo San Martin Morote Date: Wed, 15 Apr 2020 10:47:07 +0200 Subject: [PATCH] Revert "test: only call browser.end on the last test" This reverts commit 4b3ba8920d40cd4ac94bd8b1deb545b2ff550dcf. --- e2e/nightwatch.config.js | 12 ------------ e2e/specs/hash.js | 2 ++ e2e/specs/modal.js | 8 ++++++++ 3 files changed, 10 insertions(+), 12 deletions(-) diff --git a/e2e/nightwatch.config.js b/e2e/nightwatch.config.js index ef6a400f..75a974e4 100644 --- a/e2e/nightwatch.config.js +++ b/e2e/nightwatch.config.js @@ -54,18 +54,6 @@ module.exports = { }, }, - // TODO: generate these and add skip tags - 'chrome-headless': { - desiredCapabilities: { - browserName: 'chrome', - acceptSslCerts: true, - chromeOptions: { - w3c: false, - args: ['window-size=1280,800', 'headless'], - }, - }, - }, - safari: { desiredCapabilities: { browserName: 'safari', diff --git a/e2e/specs/hash.js b/e2e/specs/hash.js index 6e37b2e3..bb8c89e9 100644 --- a/e2e/specs/hash.js +++ b/e2e/specs/hash.js @@ -37,6 +37,8 @@ module.exports = { // the unencoded version, no check for the url because changes based on browser .click('li:nth-child(5) a') .assert.containsText('#param', 'é') + + .end() }, /** @type {import('nightwatch').NightwatchTest} */ diff --git a/e2e/specs/modal.js b/e2e/specs/modal.js index f17a5f77..6b21853b 100644 --- a/e2e/specs/modal.js +++ b/e2e/specs/modal.js @@ -19,6 +19,8 @@ module.exports = { .assert.urlEquals(baseURL + '/users/1') .assert.visible('dialog') .assert.containsText('dialog', 'User #1') + + .end() }, /** @type {import('nightwatch').NightwatchTest} */ @@ -42,6 +44,8 @@ module.exports = { .forward() .assert.visible('dialog') .assert.urlEquals(baseURL + '/users/1') + + .end() }, /** @type {import('nightwatch').NightwatchTest} */ @@ -61,6 +65,8 @@ module.exports = { .assert.urlEquals(baseURL + '/') .assert.containsText('h1', 'Home') .assert.not.visible('dialog') + + .end() }, /** @type {import('nightwatch').NightwatchTest} */ @@ -118,6 +124,8 @@ module.exports = { .forward() .assert.urlEquals(baseURL + '/users/1') .assert.visible('dialog') + + .end() }, /** @type {import('nightwatch').NightwatchTest} */ -- 2.47.2