From d3844bbf1e1fb6ee580e24a9746ed5753b8c00b0 Mon Sep 17 00:00:00 2001 From: Stefano Lattarini Date: Thu, 14 Feb 2013 12:32:27 +0100 Subject: [PATCH] tests on TAP: don't run the driver with perl unconditionally * t/ax/tap-setup.sh: When a 'Makefile.am' was pre-existent in the test directory at the moment the client test script sourced this file, said 'Makefile.am' was tweaked to provide it with a proper definition of TEST_LOG_DRIVER. However, there was an error in this automatic definition, since it caused the TAP test driver to be unconditionally invoked with perl. This wasn't an issue in most situations, since perl is smart enough to re-execute a given script with the proper interpreter if it sees a she-bang line that doesn't seem to point to perl itself. Still, there is no reason to do something blatantly wrong even if our tools correct the dumb mistake for us. So fix the TEST_LOG_DRIVER definition. Signed-off-by: Stefano Lattarini --- t/ax/tap-setup.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/t/ax/tap-setup.sh b/t/ax/tap-setup.sh index 4fef7b308..6955c86a0 100644 --- a/t/ax/tap-setup.sh +++ b/t/ax/tap-setup.sh @@ -36,7 +36,7 @@ fetch_tap_driver if test -f Makefile.am~; then mv -f Makefile.am~ Makefile.am \ || fatal_ "failed to restore Makefile.am" - echo 'TEST_LOG_DRIVER = $(PERL) $(srcdir)/tap-driver' >> Makefile.am \ + echo 'TEST_LOG_DRIVER = $(srcdir)/tap-driver' >> Makefile.am \ || fatal_ "failed to update Makefile.am" $AUTOMAKE Makefile \ || fatal_ "failed to remake Makefile.in" -- 2.47.2