From d3f92894471dd7306f857156a5820c53c10f8d88 Mon Sep 17 00:00:00 2001 From: Christopher Faulet Date: Wed, 23 Apr 2025 15:29:00 +0200 Subject: [PATCH] BUG/MINOR: cli: Issue an error when too many args are passed for a command When a command is parsed to split it in an array of arguments, by default, at most 64 arguments are supported. But no warning was emitted when there were too many arguments. Instead, the arguments above the limit were silently ignored. It could be an issue for some commands, like "add server", because there was no way to know some arguments were ignored. Now an error is issued when too many arguments are passed and the command is not executed. This patch should be backported to all stable versions. --- src/cli.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/src/cli.c b/src/cli.c index f06f3c907..822de4e46 100644 --- a/src/cli.c +++ b/src/cli.c @@ -806,6 +806,16 @@ static int cli_parse_request(struct appctx *appctx) } /* fill unused slots */ p = b_tail(&appctx->inbuf); + + /* throw an error if too many args are provided */ + if (*p && i == MAX_CLI_ARGS) { + char *err = NULL; + + cli_err(appctx, memprintf(&err, "Too many arguments. Commands must have at most %d arguments.\n", MAX_CLI_ARGS)); + return 0; + } + + for (; i < MAX_CLI_ARGS + 1; i++) args[i] = p; -- 2.39.5