From d42c485b8431cce292e4794b6ed5a6d34c81f0ba Mon Sep 17 00:00:00 2001 From: Samuel Cabrero Date: Mon, 6 Feb 2023 18:22:30 +0100 Subject: [PATCH] winbind:varlink: Implement get user record by name MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit $> userdbctl -s org.samba.winbind user AFOREST+user1 Enabled services: org.samba.winbind User name: AFOREST+user1 Disposition: regular Login OK: yes Password OK: no (none set) UID: 21105 GID: 20513 (unresolvable: No such process) Directory: /home/AFOREST/user1 Storage: classic Shell: /bin/bash Passwords: none Service: org.samba.winbind $> SYSTEMD_LOG_LEVEL=7 getent -spasswd:systemd passwd AFOREST+user1 varlink: Setting state idle-client /run/systemd/userdb/org.samba.winbind: Sending message: {"method":"io.systemd.UserDatabase.GetUserRecord","parameters":{"userName":"AFOREST+user1","service":"org.samba.winbind"}} /run/systemd/userdb/org.samba.winbind: Changing state idle-client → awaiting-reply /run/systemd/userdb/org.samba.winbind: New incoming message: {"parameters":{"incomplete":false,"record":{"gid":20513,"homeDirectory":"/home/AFOREST/user1","service":"org.samba.winbind","shell":"/bin/bash","uid":21105,"userName":"AFOREST+user1"}}} /run/systemd/userdb/org.samba.winbind: Changing state awaiting-reply → processing-reply /run/systemd/userdb/org.samba.winbind: Changing state processing-reply → idle-client AFOREST+user1:x:21105:20513:AFOREST+user1:/home/AFOREST/user1:/bin/bash Signed-off-by: Samuel Cabrero Reviewed-by: Andreas Schneider --- source3/winbindd/winbindd_varlink.c | 8 ++ source3/winbindd/winbindd_varlink.h | 6 + .../winbindd/winbindd_varlink_getuserrecord.c | 120 ++++++++++++++++++ 3 files changed, 134 insertions(+) diff --git a/source3/winbindd/winbindd_varlink.c b/source3/winbindd/winbindd_varlink.c index 676c0f34f16..742d0025868 100644 --- a/source3/winbindd/winbindd_varlink.c +++ b/source3/winbindd/winbindd_varlink.c @@ -188,6 +188,14 @@ static long io_systemd_getuserrecord(VarlinkService *service, flags, parm_service, parm_uid); + } else if (parm_name != NULL && parm_uid == -1) { + /* getpwnam */ + status = wb_vl_user_by_name(state, + state->ev_ctx, + call, + flags, + parm_service, + parm_name); } if (NT_STATUS_IS_ERR(status)) { diff --git a/source3/winbindd/winbindd_varlink.h b/source3/winbindd/winbindd_varlink.h index ffaa5accc4f..ddf23b437df 100644 --- a/source3/winbindd/winbindd_varlink.h +++ b/source3/winbindd/winbindd_varlink.h @@ -53,6 +53,12 @@ NTSTATUS wb_vl_user_by_uid(TALLOC_CTX *mem_ctx, uint64_t flags, const char *service, int64_t gid); +NTSTATUS wb_vl_user_by_name(TALLOC_CTX *mem_ctx, + struct tevent_context *ev_ctx, + VarlinkCall *call, + uint64_t flags, + const char *service, + const char *user_name); bool winbind_setup_varlink(TALLOC_CTX *mem_ctx, struct tevent_context *ev_ctx); diff --git a/source3/winbindd/winbindd_varlink_getuserrecord.c b/source3/winbindd/winbindd_varlink_getuserrecord.c index 6bd6417fae5..874d128672f 100644 --- a/source3/winbindd/winbindd_varlink_getuserrecord.c +++ b/source3/winbindd/winbindd_varlink_getuserrecord.c @@ -19,6 +19,7 @@ #include "includes.h" #include "winbindd.h" +#include "lib/util/string_wrappers.h" #include "winbindd_varlink.h" static void @@ -472,3 +473,122 @@ fail: TALLOC_FREE(s); return status; } + +/****************************************************************************** + * User by name + *****************************************************************************/ + +struct user_by_name_state { + struct tevent_context *ev_ctx; + struct winbindd_request *fake_req; + struct winbindd_cli_state *fake_cli; + VarlinkCall *call; +}; + +static int user_by_name_state_destructor(struct user_by_name_state *s) +{ + if (s->call != NULL) { + s->call = varlink_call_unref(s->call); + } + + return 0; +} + +static void user_by_name_getpwnam_done(struct tevent_req *req) +{ + struct user_by_name_state *s = + tevent_req_callback_data(req, struct user_by_name_state); + struct winbindd_response *response = NULL; + NTSTATUS status; + + /* winbindd_*_recv functions expect a talloc-allocated response */ + response = talloc_zero(s, struct winbindd_response); + if (response == NULL) { + DBG_ERR("No memory\n"); + varlink_call_reply_error( + s->call, + WB_VL_REPLY_ERROR_SERVICE_NOT_AVAILABLE, + NULL); + goto out; + } + + status = winbindd_getpwnam_recv(req, response); + TALLOC_FREE(req); + + if (NT_STATUS_EQUAL(status, NT_STATUS_NONE_MAPPED)) { + varlink_call_reply_error(s->call, + WB_VL_REPLY_ERROR_NO_RECORD_FOUND, + NULL); + goto out; + } else if (NT_STATUS_IS_ERR(status)) { + DBG_ERR("winbindd_getpwnam failed: %s\n", nt_errstr(status)); + varlink_call_reply_error( + s->call, + WB_VL_REPLY_ERROR_SERVICE_NOT_AVAILABLE, + NULL); + goto out; + } + + user_record_reply(s->call, &response->data.pw, false); +out: + TALLOC_FREE(s); +} + +NTSTATUS wb_vl_user_by_name(TALLOC_CTX *mem_ctx, + struct tevent_context *ev_ctx, + VarlinkCall *call, + uint64_t flags, + const char *service, + const char *user_name) +{ + struct user_by_name_state *s = NULL; + struct tevent_req *req = NULL; + NTSTATUS status; + + s = talloc_zero(mem_ctx, struct user_by_name_state); + if (s == NULL) { + DBG_ERR("No memory\n"); + return NT_STATUS_NO_MEMORY; + } + talloc_set_destructor(s, user_by_name_state_destructor); + + s->fake_cli = talloc_zero(s, struct winbindd_cli_state); + if (s->fake_cli == NULL) { + DBG_ERR("No memory\n"); + status = NT_STATUS_NO_MEMORY; + goto fail; + } + + s->fake_req = talloc_zero(s, struct winbindd_request); + if (s->fake_req == NULL) { + DBG_ERR("No memory\n"); + status = NT_STATUS_NO_MEMORY; + goto fail; + } + + s->ev_ctx = ev_ctx; + s->call = varlink_call_ref(call); + + status = wb_vl_fake_cli_state(call, service, s->fake_cli); + if (NT_STATUS_IS_ERR(status)) { + DBG_ERR("Failed to create fake winbindd_cli_state: %s\n", + nt_errstr(status)); + goto fail; + } + + s->fake_req->cmd = WINBINDD_GETPWNAM; + fstrcpy(s->fake_req->data.username, user_name); + + req = winbindd_getpwnam_send(s, s->ev_ctx, s->fake_cli, s->fake_req); + if (req == NULL) { + DBG_ERR("No memory\n"); + status = NT_STATUS_NO_MEMORY; + goto fail; + } + tevent_req_set_callback(req, user_by_name_getpwnam_done, s); + + return NT_STATUS_OK; +fail: + TALLOC_FREE(s); + return status; +} -- 2.47.2