From d45ee636a8474217ed2ee2bc3305e7d1e715df96 Mon Sep 17 00:00:00 2001 From: Ed Schonberg Date: Sat, 5 Jun 2021 20:05:31 -0400 Subject: [PATCH] [Ada] Diagnose properly illegal uses of Target_Name gcc/ada/ * sem_ch5.adb (Analyze_Target_Name): Properly reject a Target_Name when it appears outside of an assignment statement, or within the left-hand side of one. --- gcc/ada/sem_ch5.adb | 40 ++++++++++++++++++++++++++++++++++++++++ 1 file changed, 40 insertions(+) diff --git a/gcc/ada/sem_ch5.adb b/gcc/ada/sem_ch5.adb index f9813a5e4fae..82c33a204a84 100644 --- a/gcc/ada/sem_ch5.adb +++ b/gcc/ada/sem_ch5.adb @@ -4233,10 +4233,50 @@ package body Sem_Ch5 is ------------------------- procedure Analyze_Target_Name (N : Node_Id) is + procedure Report_Error; + + ------------------ + -- Report_Error -- + ------------------ + + procedure Report_Error is + begin + Error_Msg_N + ("must appear in the right-hand side of an assignment statement", + N); + Rewrite (N, New_Occurrence_Of (Any_Id, Sloc (N))); + end Report_Error; + begin -- A target name has the type of the left-hand side of the enclosing -- assignment. + -- First, verify that the context is the right-hand side of an + -- assignment statement. + + if No (Current_Assignment) then + Report_Error; + return; + + else + declare + P : Node_Id := N; + begin + while Present (P) + and then Nkind (Parent (P)) /= N_Assignment_Statement + loop + P := Parent (P); + end loop; + + if No (P) + or else P /= Expression (Parent (P)) + then + Report_Error; + return; + end if; + end; + end if; + Set_Etype (N, Etype (Name (Current_Assignment))); end Analyze_Target_Name; -- 2.47.2