From d6130aa0e70674fad1e3e263302ef4412fb3d896 Mon Sep 17 00:00:00 2001 From: Mingyu Park Date: Fri, 31 Jan 2025 23:08:46 +0900 Subject: [PATCH] lint: fix lint --- lib/sqlalchemy/dialects/mysql/base.py | 2 +- test/dialect/mysql/test_compiler.py | 13 +++++++++---- 2 files changed, 10 insertions(+), 5 deletions(-) diff --git a/lib/sqlalchemy/dialects/mysql/base.py b/lib/sqlalchemy/dialects/mysql/base.py index af546cdcd8..96eecc2ba6 100644 --- a/lib/sqlalchemy/dialects/mysql/base.py +++ b/lib/sqlalchemy/dialects/mysql/base.py @@ -1405,7 +1405,7 @@ class MySQLCompiler(compiler.SQLCompiler): coercions.expect_as_key(roles.DMLColumnRole, key): value for key, value in on_duplicate.update.items() } - + # traverses through all table columns to preserve table column order for column in (col for col in cols if col.key in on_duplicate_update): val = on_duplicate_update[column.key] diff --git a/test/dialect/mysql/test_compiler.py b/test/dialect/mysql/test_compiler.py index b2eb6033dc..8387d4e07c 100644 --- a/test/dialect/mysql/test_compiler.py +++ b/test/dialect/mysql/test_compiler.py @@ -1346,10 +1346,11 @@ class InsertOnDuplicateTest(fixtures.TestBase, AssertsCompiledSQL): }, dialect=dialect, ) - + def test_on_update_instrumented_attribute_dict(self): class Base(DeclarativeBase): pass + class T(Base): __tablename__ = "table" @@ -1357,11 +1358,15 @@ class InsertOnDuplicateTest(fixtures.TestBase, AssertsCompiledSQL): q = insert(T).values(foo=1).on_duplicate_key_update({T.foo: 2}) self.assert_compile( - q, - "INSERT INTO `table` (foo) VALUES (%s) ON DUPLICATE KEY UPDATE foo = %s", - {"foo": 1, "param_1": 2} + q, + ( + "INSERT INTO `table` (foo) VALUES (%s) " + "ON DUPLICATE KEY UPDATE foo = %s" + ), + {"foo": 1, "param_1": 2}, ) + class RegexpCommon(testing.AssertsCompiledSQL): def setup_test(self): self.table = table( -- 2.47.3