From d650e962d8f2d6ba57b2cd76ecd0c31906fd2d5a Mon Sep 17 00:00:00 2001 From: Eugene Syromiatnikov Date: Mon, 15 Sep 2025 03:31:31 +0200 Subject: [PATCH] crypto/x509/t_x509.c: check i2d_X509_NAME() return value in X509_ocspid_print() There is little reason for this call to fail, but there is also little reason for not to check for it, and, since Coverity noticed that the check is missing, just add it. Resolves: https://scan5.scan.coverity.com/#/project-view/65248/10222?selectedIssue=1665420 References: https://github.com/openssl/project/issues/1432 Signed-off-by: Eugene Syromiatnikov Reviewed-by: Paul Dale Reviewed-by: Matt Caswell (Merged from https://github.com/openssl/openssl/pull/28647) --- crypto/x509/t_x509.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/crypto/x509/t_x509.c b/crypto/x509/t_x509.c index fadf8cbbec1..e31f1c231ed 100644 --- a/crypto/x509/t_x509.c +++ b/crypto/x509/t_x509.c @@ -224,7 +224,8 @@ int X509_ocspid_print(BIO *bp, X509 *x) goto err; if ((der = dertmp = OPENSSL_malloc(derlen)) == NULL) goto err; - i2d_X509_NAME(subj, &dertmp); + if (i2d_X509_NAME(subj, &dertmp) < 0) + goto err; md = EVP_MD_fetch(x->libctx, SN_sha1, x->propq); if (md == NULL) -- 2.47.3