From d6bd4356223b0af6281cad93dab0627e17ed2f29 Mon Sep 17 00:00:00 2001 From: Markus Rietzler Date: Wed, 26 Dec 2012 19:33:32 -0700 Subject: [PATCH] Bug 3712: Rotating logs overwrites the previous log --- helpers/log_daemon/file/log_file_daemon.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/helpers/log_daemon/file/log_file_daemon.cc b/helpers/log_daemon/file/log_file_daemon.cc index 5b46c1854c..5c365891d3 100644 --- a/helpers/log_daemon/file/log_file_daemon.cc +++ b/helpers/log_daemon/file/log_file_daemon.cc @@ -61,8 +61,8 @@ rotate(const char *path, int rotate_count) fprintf(stderr, "WARNING: remove '%s' failure: %s\n", to, xstrerror()); } #endif - if (rename(path, to) < 0 && errno != ENOENT) { - fprintf(stderr, "WARNING: rename '%s' to '%s' failure: %s\n", path, to, xstrerror()); + if (rename(from, to) < 0 && errno != ENOENT) { + fprintf(stderr, "WARNING: rename '%s' to '%s' failure: %s\n", from, to, xstrerror()); } } if (rotate_count > 0) { -- 2.47.2