From d708bc6e4f580298a21c49449e2e451d3ad43440 Mon Sep 17 00:00:00 2001 From: Yu Watanabe Date: Tue, 15 Feb 2022 03:24:27 +0900 Subject: [PATCH] network: netdev: make netdev_is_ready_to_create() return negative errno on fatal error --- src/network/netdev/netdev.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/network/netdev/netdev.c b/src/network/netdev/netdev.c index a40a93d6614..fb16c255a61 100644 --- a/src/network/netdev/netdev.c +++ b/src/network/netdev/netdev.c @@ -621,7 +621,7 @@ int netdev_join(NetDev *netdev, Link *link, link_netlink_message_handler_t callb return 0; } -static bool netdev_is_ready_to_create(NetDev *netdev, Link *link) { +static int netdev_is_ready_to_create(NetDev *netdev, Link *link) { assert(netdev); assert(link); @@ -653,8 +653,9 @@ int request_process_stacked_netdev(Request *req) { assert(req->netdev); assert(req->netlink_handler); - if (!netdev_is_ready_to_create(req->netdev, req->link)) - return 0; + r = netdev_is_ready_to_create(req->netdev, req->link); + if (r <= 0) + return r; r = netdev_join(req->netdev, req->link, req->netlink_handler); if (r < 0) -- 2.47.3