From d7f3a0b0c2016c427331e6ca93735eb3e36c3c02 Mon Sep 17 00:00:00 2001 From: Iain Sandoe Date: Fri, 6 Sep 2019 15:56:18 +0000 Subject: [PATCH] [Darwin, testsuite] Fix PR63891 (darwin-weakimport-3). This is a testcase failing because one part of the codegen is (correctly) generating the scan-asm-not signature. Fixed by altering the build options. 2019-09-06 Iain Sandoe Backport from mainline. 2019-05-21 Iain Sandoe PR target/63891 * gcc.dg/darwin-weakimport-3.c: Adjust options and explain the reasons. From-SVN: r275467 --- gcc/testsuite/ChangeLog | 9 +++++++++ gcc/testsuite/gcc.dg/darwin-weakimport-3.c | 17 ++++++++++++++++- 2 files changed, 25 insertions(+), 1 deletion(-) diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog index c665cd8062d1..f48b57ad6230 100644 --- a/gcc/testsuite/ChangeLog +++ b/gcc/testsuite/ChangeLog @@ -1,3 +1,12 @@ +2019-09-06 Iain Sandoe + + Backport from mainline. + 2019-05-21 Iain Sandoe + + PR target/63891 + * gcc.dg/darwin-weakimport-3.c: Adjust options and explain + the reasons. + 2019-09-06 Iain Sandoe Backport from mainline. diff --git a/gcc/testsuite/gcc.dg/darwin-weakimport-3.c b/gcc/testsuite/gcc.dg/darwin-weakimport-3.c index 77ab980b12d1..a15b5b0e7cb9 100644 --- a/gcc/testsuite/gcc.dg/darwin-weakimport-3.c +++ b/gcc/testsuite/gcc.dg/darwin-weakimport-3.c @@ -1,5 +1,20 @@ /* { dg-do compile { target *-*-darwin* } } */ -/* { dg-options "-fno-asynchronous-unwind-tables" } */ + +/* Here we want to test if "foo" gets placed into a coalesced + section (it should not). + + However, for i386, and PIC code we have a "get_pc thunk" that + is (correctly) placed in a coalesced section when using an older + linker - also unwind tables are emitted into coalesced. + + With modern linkers this is moot, since even weak symbols + are emitted into the regular sections. + + To avoid the unwind tables -fno-asynchronous-unwind-tables. + To ensure that we emit code for an older linker -mtarget-linker + To avoid the get_pc thunk optimise at least O1. */ + +/* { dg-options "-fno-asynchronous-unwind-tables -O1 -mtarget-linker 85.2" } */ /* { dg-require-weak "" } */ /* { dg-final { scan-assembler-not "coalesced" } } */ -- 2.47.2