From d8242c5d07bda49eeac539c99eb3267190bb8e1e Mon Sep 17 00:00:00 2001 From: Jason Ish Date: Fri, 13 Nov 2020 13:05:48 -0600 Subject: [PATCH] dns: fix leak in dns v1 logging Intermediate JsonBuilder object was not being freed. Redmine issue: https://redmine.openinfosecfoundation.org/issues/4086 --- src/output-json-dns.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/output-json-dns.c b/src/output-json-dns.c index f08d562ceb..1e922d9b63 100644 --- a/src/output-json-dns.c +++ b/src/output-json-dns.c @@ -381,6 +381,7 @@ static int JsonDnsLoggerToClient(ThreadVars *tv, void *thread_data, break; } jb_set_object(jb, "dns", answer); + jb_free(answer); MemBufferReset(td->buffer); OutputJsonBuilderBuffer(jb, td->file_ctx, &td->buffer); @@ -401,6 +402,7 @@ static int JsonDnsLoggerToClient(ThreadVars *tv, void *thread_data, break; } jb_set_object(jb, "dns", answer); + jb_free(answer); MemBufferReset(td->buffer); OutputJsonBuilderBuffer(jb, td->file_ctx, &td->buffer); -- 2.47.2