From d86200ac489e08be1831b524d2268b2a1b0f222f Mon Sep 17 00:00:00 2001 From: Peter van Dijk Date: Tue, 15 Aug 2023 10:28:46 +0200 Subject: [PATCH] coverity CID 398388: useless <0 check on unsigned value --- pdns/dnsdistdist/dnsdist-discovery.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pdns/dnsdistdist/dnsdist-discovery.cc b/pdns/dnsdistdist/dnsdist-discovery.cc index ead9daf55f..2d3c66e722 100644 --- a/pdns/dnsdistdist/dnsdist-discovery.cc +++ b/pdns/dnsdistdist/dnsdist-discovery.cc @@ -275,7 +275,7 @@ bool ServiceDiscovery::getDiscoveredConfig(const UpgradeableBackend& upgradeable const struct timeval remainingTime = {.tv_sec = backend->d_config.tcpRecvTimeout, .tv_usec = 0}; uint16_t responseSize = 0; auto got = readn2WithTimeout(sock.getHandle(), &responseSize, sizeof(responseSize), remainingTime); - if (got < 0 || static_cast(got) != sizeof(responseSize)) { + if (static_cast(got) != sizeof(responseSize)) { if (g_verbose) { warnlog("Error while waiting for the ADD upgrade response size from backend %s: %d", addr.toStringWithPort(), got); } -- 2.47.2