From d8b6af3c58a181a9a63e114d8e683d8069cd0d3b Mon Sep 17 00:00:00 2001 From: Mike Bayer Date: Mon, 14 Mar 2022 15:38:01 -0400 Subject: [PATCH] changelog updates Change-Id: I6e1bcdab140eb91926520984e6fc2c288f1dade1 --- docs/build/unreleased/1004.rst | 4 ++-- docs/build/unreleased/977.rst | 16 +++++++++------- docs/build/unreleased/986.rst | 6 ++++-- 3 files changed, 15 insertions(+), 11 deletions(-) diff --git a/docs/build/unreleased/1004.rst b/docs/build/unreleased/1004.rst index b6a6908a..d629306b 100644 --- a/docs/build/unreleased/1004.rst +++ b/docs/build/unreleased/1004.rst @@ -5,5 +5,5 @@ Fixed issue where using :meth:`.Operations.create_table` in conjunction with a :class:`.CheckConstraint` that referred to table-bound :class:`.Column` objects rather than string expressions would be added to - the parent table twice, resulting in an incorrect DDL sequence. Pull - request courtesy Nicolas CANIART. + the parent table potentially multiple times, resulting in an incorrect DDL + sequence. Pull request courtesy Nicolas CANIART. diff --git a/docs/build/unreleased/977.rst b/docs/build/unreleased/977.rst index e95e4b30..91fb76ac 100644 --- a/docs/build/unreleased/977.rst +++ b/docs/build/unreleased/977.rst @@ -2,10 +2,12 @@ :tags: bug, mssql :tickets: 977 - Fixed bug where an alter_column() operation would change a "NOT NULL" - column to "NULL" by emitting an ALTER COLUMN statement that did not specify - "NOT NULL". (In the absence of "NOT NULL" T-SQL was implicitly assuming - "NULL"). An alter_column() operation that specifies `type_=` should also - specify either `nullable=` or `existing_nullable=` to inform Alembic as to - whether the emitted DDL should include "NULL" or "NOT NULL"; a warning is - now emitted if this is missing under this scenario. + Fixed bug where an :meth:`.Operations.alter_column` operation would change + a "NOT NULL" column to "NULL" by emitting an ALTER COLUMN statement that + did not specify "NOT NULL". (In the absence of "NOT NULL" T-SQL was + implicitly assuming "NULL"). An :meth:`.Operations.alter_column` operation + that specifies :paramref:`.Operations.alter_column.type` should also + specify include either :paramref:`.Operations.alter_column.nullable` or + :paramref:`.Operations.alter_column.existing_nullable` to inform Alembic as + to whether the emitted DDL should include "NULL" or "NOT NULL"; a warning + is now emitted if this is missing under this scenario. diff --git a/docs/build/unreleased/986.rst b/docs/build/unreleased/986.rst index 6834d9d1..a1b48cc5 100644 --- a/docs/build/unreleased/986.rst +++ b/docs/build/unreleased/986.rst @@ -2,6 +2,8 @@ :tags: bug, environment :tickets: 986 - The ``fileConfig()`` line in the ``env.py`` templates is now conditional on - ``Config.config_file_name`` not being None. + The ``logging.fileConfig()`` line in ``env.py`` templates, which is used + to setup Python logging for the migration run, is now conditional on + :attr:`.Config.config_file_name` not being ``None``. Otherwise, the line + is skipped as there is no default logging configuration present. -- 2.47.2