From d98aaff4243563d3939a047816ec11d0d93298bf Mon Sep 17 00:00:00 2001 From: Stephan Bosch Date: Mon, 13 Aug 2018 19:23:31 +0200 Subject: [PATCH] lib-http: test-http-client-errors: Make "peer reuse failure" test reliable. It was highly timing-sensitive, since it required a particular error status to be returned. Sometimes, it would yield a different error based on a slightly different order of events, making the test fail. Such failures aren't relevant though, since this regression test is about triggering a segfault that used to occur. --- src/lib-http/test-http-client-errors.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/lib-http/test-http-client-errors.c b/src/lib-http/test-http-client-errors.c index f74d051809..5c311687a5 100644 --- a/src/lib-http/test-http-client-errors.c +++ b/src/lib-http/test-http-client-errors.c @@ -2668,7 +2668,7 @@ test_client_peer_reuse_failure_response2( if (debug) i_debug("RESPONSE: %u %s", resp->status, resp->reason); - test_assert(resp->status == HTTP_CLIENT_REQUEST_ERROR_CONNECT_FAILED); + test_assert((resp->status / 100) > 2); test_assert(resp->reason != NULL && *resp->reason != '\0'); i_free(ctx); io_loop_stop(ioloop); -- 2.47.3