From d9a257ec85ff58b1a706d0a4f05952399cbd755b Mon Sep 17 00:00:00 2001 From: Aarni Koskela Date: Wed, 5 Mar 2025 09:18:05 +0200 Subject: [PATCH] Mark PyPy test failing in CI as xfail (#1197) --- .github/workflows/ci.yml | 1 - tests/messages/test_setuptools_frontend.py | 7 +++++++ 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 2fb4b371..a5ed97f2 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -61,7 +61,6 @@ jobs: env: COVERAGE_XML_PATH: ${{ runner.temp }} BABEL_TOX_EXTRA_DEPS: pytest-github-actions-annotate-failures - LC_ALL: C # Python 3.10.16[pypy-7.3.19-final] in GHA failed with "unsupported locale setting" - uses: codecov/codecov-action@v5 with: directory: ${{ runner.temp }} diff --git a/tests/messages/test_setuptools_frontend.py b/tests/messages/test_setuptools_frontend.py index a623efd2..5c3f4433 100644 --- a/tests/messages/test_setuptools_frontend.py +++ b/tests/messages/test_setuptools_frontend.py @@ -45,6 +45,13 @@ def test_extract_distutils_keyword_arg_388(kwarg, expected): assert set(cmdinst.add_comments) == {"Bar", "Foo"} +@pytest.mark.xfail( + # Python 3.10.16[pypy-7.3.19-final] in GHA fails with "unsupported locale setting" + # in the subprocesses this test spawns. Hard to say why because it doesn't do that + # locally. + condition=(sys.implementation.name == "pypy" and "BABEL_TOX_INI_DIR" in os.environ), + reason="Test will likely fail with 'unsupported locale setting' in subprocesses; see comment", +) def test_setuptools_commands(tmp_path, monkeypatch): """ Smoke-tests all of the setuptools versions of the commands in turn. -- 2.47.2