From d9beeb68e4d21ff98787dee78e6b1e7368bf88b0 Mon Sep 17 00:00:00 2001 From: John Ferlan Date: Tue, 10 Mar 2015 18:24:49 -0400 Subject: [PATCH] conf: Resolve Coverity RESOURCE_LEAK Commit id 'c9027d8f' added parsing of the CapNet for offload SRIOV NIC discovery, but forgot to free the nodes --- src/conf/node_device_conf.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/conf/node_device_conf.c b/src/conf/node_device_conf.c index f9c9b6fa7a..07cc0d02fd 100644 --- a/src/conf/node_device_conf.c +++ b/src/conf/node_device_conf.c @@ -939,7 +939,7 @@ virNodeDevCapNetParseXML(xmlXPathContextPtr ctxt, xmlNodePtr orignode, lnk; size_t i = -1; int ret = -1, n = -1; - char *tmp; + char *tmp = NULL; xmlNodePtr *nodes = NULL; orignode = ctxt->node; @@ -978,6 +978,7 @@ virNodeDevCapNetParseXML(xmlXPathContextPtr ctxt, goto out; } ignore_value(virBitmapSetBit(data->net.features, val)); + VIR_FREE(tmp); } data->net.subtype = VIR_NODE_DEV_CAP_NET_LAST; @@ -1002,6 +1003,8 @@ virNodeDevCapNetParseXML(xmlXPathContextPtr ctxt, ret = 0; out: ctxt->node = orignode; + VIR_FREE(nodes); + VIR_FREE(tmp); return ret; } -- 2.47.2