From db2fc9208afe5bcdd6c128c7e314f3a2cff81190 Mon Sep 17 00:00:00 2001 From: Mats Klepsland Date: Wed, 22 Aug 2018 22:08:35 +0200 Subject: [PATCH] lua: use 'SSLVersionToString' in TlsGetCertInfo() --- src/util-lua-tls.c | 27 ++------------------------- 1 file changed, 2 insertions(+), 25 deletions(-) diff --git a/src/util-lua-tls.c b/src/util-lua-tls.c index 2a3de1b597..32f851c66e 100644 --- a/src/util-lua-tls.c +++ b/src/util-lua-tls.c @@ -159,31 +159,8 @@ static int GetCertInfo(lua_State *luastate, const Flow *f, int direction) return LuaCallbackError(luastate, "error: no cert"); /* tls.version */ - char ssl_version[32] = ""; - switch (ssl_state->server_connp.version) { - case TLS_VERSION_UNKNOWN: - snprintf(ssl_version, sizeof(ssl_version), "UNDETERMINED"); - break; - case SSL_VERSION_2: - snprintf(ssl_version, sizeof(ssl_version), "SSLv2"); - break; - case SSL_VERSION_3: - snprintf(ssl_version, sizeof(ssl_version), "SSLv3"); - break; - case TLS_VERSION_10: - snprintf(ssl_version, sizeof(ssl_version), "TLSv1"); - break; - case TLS_VERSION_11: - snprintf(ssl_version, sizeof(ssl_version), "TLS 1.1"); - break; - case TLS_VERSION_12: - snprintf(ssl_version, sizeof(ssl_version), "TLS 1.2"); - break; - default: - snprintf(ssl_version, sizeof(ssl_version), "0x%04x", - ssl_state->server_connp.version); - break; - } + char ssl_version[SSL_VERSION_MAX_STRLEN]; + SSLVersionToString(ssl_state->server_connp.version, ssl_version); int r = LuaPushStringBuffer(luastate, (uint8_t *)ssl_version, strlen(ssl_version)); r += LuaPushStringBuffer(luastate, (uint8_t *)connp->cert0_subject, strlen(connp->cert0_subject)); -- 2.47.2