From dbdae96312bcccd0820d8ee43c088d5d6a1fab14 Mon Sep 17 00:00:00 2001 From: Daniel Ruf Date: Thu, 29 Mar 2018 20:41:14 +0200 Subject: [PATCH] fix: always use absolute positioning to prevent jumping Orbit slider --- js/foundation.orbit.js | 5 ++--- scss/components/_orbit.scss | 1 + 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/js/foundation.orbit.js b/js/foundation.orbit.js index 38b837904..7d34a897f 100644 --- a/js/foundation.orbit.js +++ b/js/foundation.orbit.js @@ -344,11 +344,10 @@ class Orbit extends Plugin { if (this.options.useMUI && !this.$element.is(':hidden')) { Motion.animateIn( - $newSlide.addClass('is-active').css({'position': 'absolute', 'top': 0}), + $newSlide.addClass('is-active'), this.options[`animInFrom${dirIn}`], function(){ - $newSlide.css({'position': 'relative', 'display': 'block'}) - .attr('aria-live', 'polite'); + $newSlide.attr('aria-live', 'polite'); }); Motion.animateOut( diff --git a/scss/components/_orbit.scss b/scss/components/_orbit.scss index 9b43fcdd4..988c291dc 100644 --- a/scss/components/_orbit.scss +++ b/scss/components/_orbit.scss @@ -67,6 +67,7 @@ $orbit-control-zindex: 10 !default; /// Adds styles for the individual slides of an Orbit slider. These styles are used on the `.orbit-slide` class. @mixin orbit-slide { width: 100%; + position: absolute; &.no-motionui { &.is-active { -- 2.47.2