From dc03aed6a186b2e2d6749beae0a70560a73acc2d Mon Sep 17 00:00:00 2001 From: Peter Krempa Date: Mon, 22 Mar 2021 17:03:47 +0100 Subject: [PATCH] qemuDomainStorageSourceValidateDepth: Define chain depth as macro MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit The magic constant will be used in one more place. Signed-off-by: Peter Krempa Reviewed-by: Ján Tomko --- src/qemu/qemu_domain.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index 03858a1340..3624ed035f 100644 --- a/src/qemu/qemu_domain.c +++ b/src/qemu/qemu_domain.c @@ -7462,6 +7462,8 @@ qemuDomainStorageAlias(const char *device, int depth) } +#define QEMU_DOMAIN_STORAGE_SOURCE_CHAIN_MAX_DEPTH 200 + /** * qemuDomainStorageSourceValidateDepth: * @src: storage source chain to validate @@ -7474,8 +7476,9 @@ qemuDomainStorageAlias(const char *device, int depth) * when formatted to the XML. * * This function validates that the storage source chain starting @src is at - * most 200 layers deep. @add modifies the calculated value to offset the number - * to allow checking cases when new layers are going to be added to the chain. + * most QEMU_DOMAIN_STORAGE_SOURCE_CHAIN_MAX_DEPTH layers deep. @add modifies + * the calculated value to offset the number to allow checking cases when new + * layers are going to be added to the chain. * * Returns 0 on success and -1 if the chain is too deep. Error is reported. */ @@ -7492,7 +7495,7 @@ qemuDomainStorageSourceValidateDepth(virStorageSourcePtr src, nlayers += add; - if (nlayers > 200) { + if (nlayers > QEMU_DOMAIN_STORAGE_SOURCE_CHAIN_MAX_DEPTH) { if (diskdst) virReportError(VIR_ERR_OPERATION_UNSUPPORTED, _("backing chains more than 200 layers deep are not " -- 2.47.2