From dc7f3ffc023e3decf6aca3a2cfba2d884f0413a4 Mon Sep 17 00:00:00 2001 From: "Daniel P. Berrange" Date: Wed, 19 Mar 2014 10:55:13 +0000 Subject: [PATCH] Remove bogus unref in virDBusMessageRead The virDBusMessageRead method should not have side-effects on the message parameter passed in, so unref'ing it is wrong. The caller should unref only when they decided they are done with it. Signed-off-by: Daniel P. Berrange --- src/util/virdbus.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/util/virdbus.c b/src/util/virdbus.c index ecfe9f6364..cbaf995813 100644 --- a/src/util/virdbus.c +++ b/src/util/virdbus.c @@ -1421,7 +1421,6 @@ int virDBusMessageRead(DBusMessage *msg, ret = virDBusMessageDecodeArgs(msg, types, args); va_end(args); - dbus_message_unref(msg); return ret; } -- 2.47.2