From dd839b1463e7ead1d16048cf4e32b0efb1b0774f Mon Sep 17 00:00:00 2001 From: Yu Watanabe Date: Wed, 28 Jan 2026 12:37:56 +0900 Subject: [PATCH] parse-util: rename trivial argument for parse_pid() The function parse_pid() trivially returns pid, hence it is not necessary to name the argument for storing result as 'ret_pid'. --- src/basic/parse-util.c | 6 +++--- src/basic/parse-util.h | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/basic/parse-util.c b/src/basic/parse-util.c index 60833d3b06c..3ccdb0001d1 100644 --- a/src/basic/parse-util.c +++ b/src/basic/parse-util.c @@ -63,7 +63,7 @@ int parse_tristate_full(const char *v, const char *third, int *ret) { return 0; } -int parse_pid(const char *s, pid_t* ret_pid) { +int parse_pid(const char *s, pid_t *ret) { unsigned long ul = 0; pid_t pid; int r; @@ -82,8 +82,8 @@ int parse_pid(const char *s, pid_t* ret_pid) { if (!pid_is_valid(pid)) return -ERANGE; - if (ret_pid) - *ret_pid = pid; + if (ret) + *ret = pid; return 0; } diff --git a/src/basic/parse-util.h b/src/basic/parse-util.h index 153553773dd..d92577c0fbe 100644 --- a/src/basic/parse-util.h +++ b/src/basic/parse-util.h @@ -10,7 +10,7 @@ int parse_tristate_full(const char *v, const char *third, int *ret); static inline int parse_tristate(const char *v, int *ret) { return parse_tristate_full(v, NULL, ret); } -int parse_pid(const char *s, pid_t* ret_pid); +int parse_pid(const char *s, pid_t *ret); int parse_mode(const char *s, mode_t *ret); int parse_ifindex(const char *s); int parse_mtu(int family, const char *s, uint32_t *ret); -- 2.47.3