From dddb0198c2a887c2eba1a8b0113b46b648163048 Mon Sep 17 00:00:00 2001 From: Alok Tiwari Date: Thu, 5 Feb 2026 01:19:55 -0800 Subject: [PATCH] net: marvell: prestera: fix FEC error message for SFP ports In prestera_ethtool_set_fecparam(), the error message is opposite of the condition checking PRESTERA_PORT_TCVR_SFP. FEC configuration is not allowed on SFP ports, but the message says "non-SFP ports", which does not match the condition. However, FEC may be required depending on the transceiver, cable, or mode, and firmware already validates invalid combinations. Remove the SFP transceiver check and let firmware handle validation. Signed-off-by: Alok Tiwari Acked-by: Elad Nachman Link: https://patch.msgid.link/20260205091958.231413-1-alok.a.tiwari@oracle.com Signed-off-by: Jakub Kicinski --- drivers/net/ethernet/marvell/prestera/prestera_ethtool.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/drivers/net/ethernet/marvell/prestera/prestera_ethtool.c b/drivers/net/ethernet/marvell/prestera/prestera_ethtool.c index 2f52daba58e6c..750c72f628e54 100644 --- a/drivers/net/ethernet/marvell/prestera/prestera_ethtool.c +++ b/drivers/net/ethernet/marvell/prestera/prestera_ethtool.c @@ -717,11 +717,6 @@ static int prestera_ethtool_set_fecparam(struct net_device *dev, return -EINVAL; } - if (port->caps.transceiver == PRESTERA_PORT_TCVR_SFP) { - netdev_err(dev, "FEC set is not allowed on non-SFP ports\n"); - return -EINVAL; - } - fec = PRESTERA_PORT_FEC_MAX; for (mode = 0; mode < PRESTERA_PORT_FEC_MAX; mode++) { if ((port_fec_caps[mode].eth_fec & fecparam->fec) && -- 2.47.3