From deaa83af700113c99835a1db7d45d33baba05bd3 Mon Sep 17 00:00:00 2001 From: Tomas Mraz Date: Mon, 6 May 2024 20:13:52 +0200 Subject: [PATCH] Fix Coverity issues 1596850, 1596851 and 1596852 These are newly introduced memory leaks and UAF in evp_test.c Reviewed-by: Neil Horman Reviewed-by: Paul Dale (Merged from https://github.com/openssl/openssl/pull/24339) --- test/evp_test.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/test/evp_test.c b/test/evp_test.c index 5da782d0def..21106dd6334 100644 --- a/test/evp_test.c +++ b/test/evp_test.c @@ -411,10 +411,10 @@ static int parse_bin_chunk(const char *value, size_t offset, size_t max, return -1; if (!TEST_ptr(*buf = OPENSSL_hexstr2buf(chunk, &len))) { OPENSSL_free(chunk); - TEST_info("Can't convert chunk %s", chunk); TEST_openssl_errors(); return -1; } + OPENSSL_free(chunk); *buflen = len; } *out_offset = value[0] == '"' ? offset + (*buflen) : offset + 2 * (*buflen); @@ -742,6 +742,8 @@ static int cipher_test_init(EVP_TEST *t, const char *alg) if (data_chunk_size != 0 && !cipher_test_valid_fragmentation(cdat)) { ERR_pop_to_mark(); + EVP_CIPHER_free(fetched_cipher); + OPENSSL_free(cdat); t->skip = 1; TEST_info("skipping, '%s' does not support fragmentation", alg); return 1; -- 2.47.2