From df397943196f7ff396beb41449583b4629ee99e2 Mon Sep 17 00:00:00 2001 From: Lad Prabhakar Date: Wed, 12 Nov 2025 13:57:15 +0000 Subject: [PATCH] net: phy: mscc: Handle devm_phy_package_join() failure in vsc85xx_probe_common() devm_phy_package_join() may fail and return a negative error code. Update vsc85xx_probe_common() to properly handle this failure by checking the return value and propagating the error to the caller. Signed-off-by: Lad Prabhakar Reviewed-by: Andrew Lunn Link: https://patch.msgid.link/20251112135715.1017117-5-prabhakar.mahadev-lad.rj@bp.renesas.com Signed-off-by: Jakub Kicinski --- drivers/net/phy/mscc/mscc_main.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/net/phy/mscc/mscc_main.c b/drivers/net/phy/mscc/mscc_main.c index 21fcaf07bc6d5..2b9fb8a675a65 100644 --- a/drivers/net/phy/mscc/mscc_main.c +++ b/drivers/net/phy/mscc/mscc_main.c @@ -2264,8 +2264,11 @@ static int vsc85xx_probe_common(struct phy_device *phydev, /* Set up package if needed */ if (cfg->use_package) { vsc8584_get_base_addr(phydev); - devm_phy_package_join(&phydev->mdio.dev, phydev, - vsc8531->base_addr, cfg->shared_size); + ret = devm_phy_package_join(&phydev->mdio.dev, phydev, + vsc8531->base_addr, + cfg->shared_size); + if (ret) + return ret; } /* Configure LED settings */ -- 2.47.3