From dfd70aef87f206f2ef23801d52dad76c5ab6744c Mon Sep 17 00:00:00 2001 From: Francis Dupont Date: Tue, 23 Dec 2025 14:32:16 +0100 Subject: [PATCH] [#3103] Removed not implemented realm --- doc/sphinx/arm/ext-radius.rst | 2 -- src/hooks/dhcp/radius/radius.cc | 2 -- src/hooks/dhcp/radius/radius.dox | 2 -- src/hooks/dhcp/radius/radius_parsers.cc | 5 +---- 4 files changed, 1 insertion(+), 10 deletions(-) diff --git a/doc/sphinx/arm/ext-radius.rst b/doc/sphinx/arm/ext-radius.rst index 11b3cb8190..fbd514412a 100644 --- a/doc/sphinx/arm/ext-radius.rst +++ b/doc/sphinx/arm/ext-radius.rst @@ -148,8 +148,6 @@ flags: a default. The substitution happens for all packets that did not match a selector. -- ``realm`` (default ``""``) - is the default realm. - - ``reselect-subnet-address`` (default ``false``) - enables subnet reselection according to the value of the Framed-IP-Address or, respectively, the Framed-IPv6-Address attribute from the RADIUS access response. With this diff --git a/src/hooks/dhcp/radius/radius.cc b/src/hooks/dhcp/radius/radius.cc index efdfbacdfa..fb18de4be3 100644 --- a/src/hooks/dhcp/radius/radius.cc +++ b/src/hooks/dhcp/radius/radius.cc @@ -443,8 +443,6 @@ ElementPtr RadiusImpl::toElement() const { result->set("identifier-type6", Element::create(Host::getIdentifierName(id_type6_))); - // realm. - // reselect-subnet-address. result->set("reselect-subnet-address", Element::create(reselect_subnet_address_)); diff --git a/src/hooks/dhcp/radius/radius.dox b/src/hooks/dhcp/radius/radius.dox index aed95e2224..4a7ed9d476 100644 --- a/src/hooks/dhcp/radius/radius.dox +++ b/src/hooks/dhcp/radius/radius.dox @@ -95,8 +95,6 @@ The global configuration flags are: attempted first, and if successful, it prevents the function of reselect-subnet-address from coming into effect. - - realm (default "") is the default realm. - - retries (default 3) is the number of retries before trying the next server. Not supported for asynchronous communication. diff --git a/src/hooks/dhcp/radius/radius_parsers.cc b/src/hooks/dhcp/radius/radius_parsers.cc index 4e07a3f887..dbb632f3c4 100644 --- a/src/hooks/dhcp/radius/radius_parsers.cc +++ b/src/hooks/dhcp/radius/radius_parsers.cc @@ -38,7 +38,7 @@ RadiusConfigParser::RADIUS_KEYWORDS = { "bindaddr", "canonical-mac-address", "client-id-pop0", "client-id-printable", "deadtime", "dictionary", "extract-duid", "identifier-type4", "identifier-type6", - "nas-ports", "realm", + "nas-ports", "reselect-subnet-address", "reselect-subnet-pool", "retries", "session-history", "thread-pool-size", "timeout", "comment" // not saved for toElement @@ -55,7 +55,6 @@ const SimpleDefaults RadiusConfigParser::RADIUS_DEFAULTS = { { "extract-duid", Element::boolean, "true" }, { "identifier-type4", Element::string, "client-id" }, { "identifier-type6", Element::string, "duid" }, - { "realm", Element::string, "" }, { "reselect-subnet-address", Element::boolean, "false" }, { "reselect-subnet-pool", Element::boolean, "false" }, { "retries", Element::integer, "3" }, @@ -163,8 +162,6 @@ RadiusConfigParser::parse(ElementPtr& config) { const ConstElementPtr& id_type6 = config->get("identifier-type6"); riref.id_type6_ = Host::getIdentifierType(id_type6->stringValue()); - // realm. Ignored. - // reselect-subnet-address. const ConstElementPtr& resel_addr = config->get("reselect-subnet-address"); -- 2.47.3