From dfe0ce93f29fc4470dff72ca5438034ccf741e5f Mon Sep 17 00:00:00 2001 From: =?utf8?q?J=C3=A1n=20Tomko?= Date: Mon, 26 Aug 2019 22:37:41 +0200 Subject: [PATCH] qemuBuildMemoryBackendProps: use 'rc' instead of ret. MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit Do not overwrite the 'ret' value more than once. Signed-off-by: Ján Tomko Reviewed-by: Cole Robinson --- src/qemu/qemu_command.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index c5ef79653b..df499f75e3 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -3333,7 +3333,7 @@ qemuBuildMemoryBackendProps(virJSONValuePtr *backendProps, VIR_AUTOFREE(char *) memPath = NULL; bool prealloc = false; virBitmapPtr nodemask = NULL; - int ret = -1; + int rc; VIR_AUTOPTR(virJSONValue) props = NULL; bool nodeSpecified = virDomainNumatuneNodeSpecified(def->numa, mem->targetNode); unsigned long long pagesize = mem->pagesize; @@ -3547,7 +3547,7 @@ qemuBuildMemoryBackendProps(virJSONValuePtr *backendProps, !force) { /* report back that using the new backend is not necessary * to achieve the desired configuration */ - ret = 1; + rc = 1; } else { /* otherwise check the required capability */ if (STREQ(backendType, "memory-backend-file") && @@ -3570,14 +3570,14 @@ qemuBuildMemoryBackendProps(virJSONValuePtr *backendProps, return -1; } - ret = 0; + rc = 0; } if (!(*backendProps = qemuMonitorCreateObjectPropsWrap(backendType, alias, &props))) - ret = -1; + return -1; - return ret; + return rc; } -- 2.47.2