From e054a168302999649ee1b8987dc6806daa0653a1 Mon Sep 17 00:00:00 2001 From: Stefan Eissing Date: Fri, 2 Jun 2023 15:57:46 +0200 Subject: [PATCH] curl_log: evaluate log statement only when transfer is verbose Closes #11238 --- lib/curl_log.c | 2 +- lib/curl_log.h | 12 +++++++----- 2 files changed, 8 insertions(+), 6 deletions(-) diff --git a/lib/curl_log.c b/lib/curl_log.c index 71024cfc62..c1f70a6d31 100644 --- a/lib/curl_log.c +++ b/lib/curl_log.c @@ -130,7 +130,7 @@ void Curl_log_cf_debug(struct Curl_easy *data, struct Curl_cfilter *cf, const char *fmt, ...) { DEBUGASSERT(cf); - if(data && Curl_log_cf_is_debug(cf)) { + if(data && Curl_log_cf_is_debug(cf, data)) { va_list ap; int len; char buffer[MAXINFO + 2]; diff --git a/lib/curl_log.h b/lib/curl_log.h index ad6143fa99..acf5630163 100644 --- a/lib/curl_log.h +++ b/lib/curl_log.h @@ -74,7 +74,7 @@ void Curl_debug(struct Curl_easy *data, curl_infotype type, defined(__STDC_VERSION__) && (__STDC_VERSION__ >= 199901L) #define LOG_CF(data, cf, ...) \ - do { if(Curl_log_cf_is_debug(cf)) \ + do { if(Curl_log_cf_is_debug(cf, data)) \ Curl_log_cf_debug(data, cf, __VA_ARGS__); } while(0) #else #define LOG_CF Curl_log_cf_debug @@ -90,8 +90,10 @@ void Curl_log_cf_debug(struct Curl_easy *data, struct Curl_cfilter *cf, const char *fmt, ...); #endif -#define Curl_log_cf_is_debug(cf) \ - ((cf) && (cf)->cft->log_level >= CURL_LOG_DEBUG) +#define Curl_log_cf_is_debug(cf, data) \ + ((data) && (data)->set.verbose && \ + (cf) && (cf)->cft->log_level >= CURL_LOG_DEBUG) + #else /* !DEBUGBUILD */ @@ -110,11 +112,11 @@ void Curl_log_cf_debug(struct Curl_easy *data, struct Curl_cfilter *cf, const char *fmt, ...); #endif -#define Curl_log_cf_is_debug(x) ((void)(x), FALSE) +#define Curl_log_cf_is_debug(x,y) ((void)(x), (void)(y), FALSE) #endif /* !DEBUGBUILD */ -#define LOG_CF_IS_DEBUG(x) Curl_log_cf_is_debug(x) +#define LOG_CF_IS_DEBUG(cf, data) Curl_log_cf_is_debug(cf, data) /* Macros intended for DEBUGF logging, use like: * DEBUGF(infof(data, CFMSG(cf, "this filter %s rocks"), "very much")); -- 2.47.3