From e0ddfc8e05b42266c6cf38999eed74e22214c7fa Mon Sep 17 00:00:00 2001 From: Stefan Eissing Date: Fri, 19 May 2023 09:33:59 +0200 Subject: [PATCH] ngtcp2: fix compiler warning about possible null-deref - compiler analyzer did not include the call context for this static function where the condition had already been checked. - eleminating the problem by making stream a call parameter Fixes #11147 Closes #11151 --- lib/vquic/curl_ngtcp2.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/lib/vquic/curl_ngtcp2.c b/lib/vquic/curl_ngtcp2.c index 7794f148c6..3feace04a7 100644 --- a/lib/vquic/curl_ngtcp2.c +++ b/lib/vquic/curl_ngtcp2.c @@ -1312,13 +1312,12 @@ fail: static ssize_t recv_closed_stream(struct Curl_cfilter *cf, struct Curl_easy *data, + struct stream_ctx *stream, CURLcode *err) { - struct stream_ctx *stream = H3_STREAM_CTX(data); ssize_t nread = -1; (void)cf; - DEBUGASSERT(stream); if(stream->reset) { failf(data, "HTTP/3 stream %" PRId64 " reset by server", stream->id); @@ -1413,7 +1412,7 @@ static ssize_t cf_ngtcp2_recv(struct Curl_cfilter *cf, struct Curl_easy *data, } else { if(stream->closed) { - nread = recv_closed_stream(cf, data, err); + nread = recv_closed_stream(cf, data, stream, err); goto out; } *err = CURLE_AGAIN; -- 2.47.3