From e1008bcdc96c67d23b67323b33867c6c04954406 Mon Sep 17 00:00:00 2001 From: Christian Brauner Date: Thu, 31 Aug 2017 23:08:28 +0200 Subject: [PATCH] lxc-user-nic: free memory and check for error - check for error on ifindex retrieval - free allocated memory Signed-off-by: Christian Brauner --- src/lxc/lxc_user_nic.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/src/lxc/lxc_user_nic.c b/src/lxc/lxc_user_nic.c index 1853e0412..7541e4b8a 100644 --- a/src/lxc/lxc_user_nic.c +++ b/src/lxc/lxc_user_nic.c @@ -453,6 +453,8 @@ static int get_mtu(char *name) int idx; idx = if_nametoindex(name); + if (idx < 0) + return -1; return netdev_get_mtu(idx); } @@ -1215,6 +1217,12 @@ int main(int argc, char *argv[]) exit(EXIT_FAILURE); } host_veth_ifidx = if_nametoindex(nicname); + if (!host_veth_ifidx) { + free(newname); + free(nicname); + usernic_error("Failed to get netdev index: %s\n", strerror(errno)); + exit(EXIT_FAILURE); + } /* Write names of veth pairs and their ifindeces to stout: * (e.g. eth0:731:veth9MT2L4:730) -- 2.47.2