From e1a33ed18c0200e26d92eb2900943573fc0f7d60 Mon Sep 17 00:00:00 2001 From: Michal Privoznik Date: Thu, 15 Sep 2016 17:42:36 +0200 Subject: [PATCH] testNodeGetCellsFreeMemory: Fix off by one error Consider the following scenario: virsh # freecell --all 0: 2048 KiB 1: 4096 KiB -------------------- Total: 6144 KiB virsh # freecell 0 0: 2048 KiB virsh # freecell 1 1: 4096 KiB And now before this change: virsh # freecell 2 After this change: virsh # freecell 2 error: invalid argument: Range exceeds available cells Signed-off-by: Michal Privoznik --- src/test/test_driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index dc1e5697c5..51fb7c8f3f 100644 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c @@ -2710,7 +2710,7 @@ static int testNodeGetCellsFreeMemory(virConnectPtr conn, int ret = -1; testDriverLock(privconn); - if (startCell > privconn->numCells) { + if (startCell >= privconn->numCells) { virReportError(VIR_ERR_INVALID_ARG, "%s", _("Range exceeds available cells")); goto cleanup; -- 2.47.2