From e1f7d7885752ac3a0279ecc7e31ccee2af40fbe4 Mon Sep 17 00:00:00 2001 From: Selva Nair Date: Wed, 19 Feb 2020 19:49:37 -0500 Subject: [PATCH] Fix possibly uninitialized return value in GetOpenvpnSettings() MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit Compile time warning for openvpnserv.exe common.c:90:11: warning: ‘error’ may be used uninitialized in this function [-Wmaybe-uninitialized]; Uninitialized value gets returned if install-path is not found in the registry. Fix by setting it to the return value of GetRegString(). Signed-off-by: Selva Nair Acked-by: Lev Stipakov Message-Id: <1582159777-2437-1-git-send-email-selva.nair@gmail.com> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg19479.html Signed-off-by: David Sommerseth --- src/openvpnserv/common.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/openvpnserv/common.c b/src/openvpnserv/common.c index fd517763b..958643dfd 100644 --- a/src/openvpnserv/common.c +++ b/src/openvpnserv/common.c @@ -118,8 +118,10 @@ GetOpenvpnSettings(settings_t *s) } /* The default value of REG_KEY is the install path */ - if (GetRegString(key, NULL, install_path, sizeof(install_path), NULL) != ERROR_SUCCESS) + status = GetRegString(key, NULL, install_path, sizeof(install_path), NULL); + if (status != ERROR_SUCCESS) { + error = status; goto out; } -- 2.47.2