From e33e89d8399042f55fa6999fdfaa40ee884a9bfe Mon Sep 17 00:00:00 2001 From: Peter Krempa Date: Tue, 3 Nov 2020 12:00:21 +0100 Subject: [PATCH] qemu: backup: Use VIR_ERR_CHECKPOINT_INCONSISTENT when starting a backup MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit If we don't have a consistent chain of bitmaps for the backup to proceed we'd report VIR_ERR_INVALID_ARG error code, which makes it hard to decide whether an incremental backup makes even sense. Signed-off-by: Peter Krempa Reviewed-by: Ján Tomko --- src/qemu/qemu_backup.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_backup.c b/src/qemu/qemu_backup.c index eb0682e193..2e3a2b2e3c 100644 --- a/src/qemu/qemu_backup.c +++ b/src/qemu/qemu_backup.c @@ -206,7 +206,7 @@ qemuBackupDiskPrepareOneBitmaps(struct qemuBackupDiskData *dd, if (!qemuBlockBitmapChainIsValid(dd->domdisk->src, dd->backupdisk->incremental, blockNamedNodeData)) { - virReportError(VIR_ERR_INVALID_ARG, + virReportError(VIR_ERR_CHECKPOINT_INCONSISTENT, _("missing or broken bitmap '%s' for disk '%s'"), dd->backupdisk->incremental, dd->domdisk->dst); return -1; -- 2.47.2