From e3e2793db20651c1a0f34f0986f58f85c38afb68 Mon Sep 17 00:00:00 2001 From: Eric Sandeen Date: Tue, 16 Sep 2014 09:18:56 +1000 Subject: [PATCH] xfs_fsr: free handlep in fsrfs We leaked the fshandlep in both error returns and normal function exit. Signed-off-by: Eric Sandeen Reviewed-by: Brian Foster Signed-off-by: Dave Chinner --- fsr/xfs_fsr.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/fsr/xfs_fsr.c b/fsr/xfs_fsr.c index 752d2dbdd..580604cba 100644 --- a/fsr/xfs_fsr.c +++ b/fsr/xfs_fsr.c @@ -702,6 +702,7 @@ fsrfs(char *mntdir, xfs_ino_t startino, int targetrange) if ((fsfd = open(mntdir, O_RDONLY)) < 0) { fsrprintf(_("unable to open: %s: %s\n"), mntdir, strerror( errno )); + free(fshandlep); return -1; } @@ -709,6 +710,7 @@ fsrfs(char *mntdir, xfs_ino_t startino, int targetrange) fsrprintf(_("Skipping %s: could not get XFS geometry\n"), mntdir); close(fsfd); + free(fshandlep); return -1; } @@ -774,6 +776,7 @@ fsrfs(char *mntdir, xfs_ino_t startino, int targetrange) out0: tmp_close(mntdir); close(fsfd); + free(fshandlep); return 0; } -- 2.47.2